feat: add new option for walk config #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terryhung
changed the title
birdychang
approved these changes
May 24, 2023
chain/walk/walker.go
Outdated
| @@ -102,7 +105,14 @@ func (c *Walker) WalkChain(ctx context.Context, node lens.API, ts *types.TipSet) | |||
| c.report.UpdateCurrentHeight(int64(ts.Height())) | |||
| if success, err := c.obs.TipSet(ctx, ts, indexer.WithIndexerType(indexer.Walk), indexer.WithTasks(c.tasks)); err != nil { | |||
| span.RecordError(err) | |||
| return fmt.Errorf("notify tipset: %w", err) | |||
| log.Errorf("notify tipset: %w", err) | |||
There was a problem hiding this comment.
Let's improve the log message.
| // return an error only if the "stopOnFatalError" flag is set to true. | ||
| if c.stopOnFatalError { | ||
| return err | ||
| } | ||
| } else if !success { | ||
| log.Errorw("walk incomplete", "height", ts.Height(), "tipset", ts.Key().String(), "reporter", c.name) |
There was a problem hiding this comment.
same as above so it looks consistent.
chain/walk/walker.go
Outdated
| @@ -17,28 +17,30 @@ import ( | |||
|
|
|||
| var log = logging.Logger("lily/chain/walk") | |||
|
|
|||
| func NewWalker(obs indexer.Indexer, node lens.API, name string, tasks []string, minHeight, maxHeight int64, r *schedule.Reporter) *Walker { | |||
| func NewWalker(obs indexer.Indexer, node lens.API, name string, tasks []string, minHeight, maxHeight int64, r *schedule.Reporter, stopOnFatalError bool) *Walker { | |||
There was a problem hiding this comment.
Just call it stopOnError so less verbose everywhere?
birdychang
approved these changes
May 25, 2023
commands/job/options.go
Outdated
| var StopOnFatalError = &cli.BoolFlag{ | ||
| Name: "stop-on-fatal-error", | ||
| var StopOnError = &cli.BoolFlag{ | ||
| Name: "stop-on-error", | ||
| Usage: "Stop the job if it get error.", |
There was a problem hiding this comment.
Stop the job if it encounters an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request can resolve the issue: #1210.
Usage
By default, when the stopOnFatalError flag is set to false, the process will continue from start to end without halting, regardless of any errors encountered.
To turn on the flag:
--stop-on-error=true