Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add actor dump processor and task #1245

Merged
merged 19 commits into from
Aug 16, 2023
Merged

Conversation

Terryhung
Copy link
Collaborator

@Terryhung Terryhung commented Jul 21, 2023

Add the new processor for handling new type of task: periodic actor dump.

@Terryhung Terryhung force-pushed the terryhung/add-new-processor branch from 9104494 to 8f59050 Compare July 28, 2023 07:21
@Terryhung Terryhung marked this pull request as ready for review July 28, 2023 07:21
@Terryhung Terryhung force-pushed the terryhung/add-new-processor branch from 30c90ed to e0e1bf5 Compare August 4, 2023 21:22
@Terryhung Terryhung force-pushed the terryhung/add-new-processor branch from 52614a6 to ad0c61a Compare August 11, 2023 01:46
@Terryhung Terryhung requested a review from birdychang August 14, 2023 06:12
Comment on lines 783 to 786
//
// Hourly Snapshot
//

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove or update?

@@ -155,6 +159,7 @@ var TableLookup = map[string]struct{}{
FEVMTransaction: {},
FEVMContract: {},
FEVMTrace: {},
FVMActorStateDump: {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FEVMActorDump

@@ -18,6 +18,7 @@ const (
ImplicitMessageTask = "implicitmessage" // task that extract implicitly executed messages: cron tick and block reward.
ChainConsensusTask = "consensus"
FEVMTask = "fevm"
Snapshot = "snapshot"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snapshot?

@Terryhung Terryhung force-pushed the terryhung/add-new-processor branch from 5fbdf82 to b680705 Compare August 14, 2023 09:15
@@ -66,10 +68,15 @@ import (
fevmtransactiontask "github.com/filecoin-project/lily/tasks/fevm/transaction"
fevmactorstatstask "github.com/filecoin-project/lily/tasks/fevmactorstats"

// actor dump
fvmactordumptask "github.com/filecoin-project/lily/tasks/periodic_actor_dump/fvm_actor"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use fevm to be consistent.

@@ -155,6 +159,7 @@ var TableLookup = map[string]struct{}{
FEVMTransaction: {},
FEVMContract: {},
FEVMTrace: {},
FVMActorDump: {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation.

@@ -207,6 +212,7 @@ var TableComment = map[string]string{
FEVMTransaction: ``,
FEVMContract: ``,
FEVMTrace: ``,
FVMActorDump: ``,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation.

@@ -316,4 +322,5 @@ var TableFieldComments = map[string]map[string]string{
FEVMTransaction: {},
FEVMContract: {},
FEVMTrace: {},
FVMActorDump: {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation.

@Terryhung Terryhung changed the title feat: add new processor feat: add actor dump processor and task Aug 16, 2023
@Terryhung Terryhung merged commit f77dccc into master Aug 16, 2023
@Terryhung Terryhung deleted the terryhung/add-new-processor branch August 16, 2023 14:11
@Terryhung Terryhung mentioned this pull request Aug 16, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants