Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: use numeric type to represent numbers #358

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

iand
Copy link
Contributor

@iand iand commented Jan 15, 2021

Migration 27 changes the column types in several very large tables which is extremely slow. I will add this migration back again in a new PR which we should hold until we have planned a large enough maintenance window in which to run the migration.

Reverts #327

@codecov-io
Copy link

Codecov Report

Merging #358 (aa1b702) into master (6bd1428) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #358   +/-   ##
======================================
  Coverage    42.4%   42.4%           
======================================
  Files          25      25           
  Lines        1896    1896           
======================================
  Hits          804     804           
  Misses        965     965           
  Partials      127     127           

@iand iand self-assigned this Jan 15, 2021
@iand iand requested a review from frrist January 15, 2021 11:18
@iand
Copy link
Contributor Author

iand commented Jan 15, 2021

As a data point, I ran ALTER TABLE public.derived_gas_outputs ALTER COLUMN value TYPE numeric USING (value::numeric); against the staging database and it still hasn't returned after 2.5 hours

@iand iand merged commit 655e693 into master Jan 15, 2021
@iand iand deleted the revert-327-frrist/fil-numeric branch January 15, 2021 13:56
iand added a commit that referenced this pull request Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants