fix(lily): Consider partially completed heights w ERRORs and SKIPs #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
========================================
+ Coverage 32.8% 33.0% +0.2%
========================================
Files 40 40
Lines 3704 3717 +13
========================================
+ Hits 1215 1228 +13
Misses 2353 2353
Partials 136 136 |
placer14
force-pushed
the
mg/fix/include-error-gaps
branch
from
d55abb3 to
175f509
Compare
placer14
force-pushed
the
mg/fix/include-error-gaps
branch
from
175f509 to
4259c74
Compare
frrist
reviewed
Dec 1, 2021
chain/find.go
Outdated
| on vpr.height = incomplete.height | ||
| where (vpr.status_information != ?1 | ||
| or vpr.status_information is null) | ||
| and vpr.status = ?5 |
There was a problem hiding this comment.
I've added notes within the query to explain what's happening here.
chain/find.go
Outdated
| visor.ProcessingStatusInformationNullRound, // arg 1 | ||
| g.minHeight, // arg 2 | ||
| g.maxHeight, // arg 3 | ||
| visor.ProcessingStatusError, // arg 4 |
There was a problem hiding this comment.
I've added notes within the query to explain what's happening here.
placer14
changed the title
placer14
force-pushed
the
mg/fix/include-error-gaps
branch
3 times, most recently
from
c8caee5 to
c663469
Compare
placer14
force-pushed
the
mg/fix/include-error-gaps
branch
from
c663469 to
399f5e8
Compare
frrist
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #773
fixes #775