chore(deps): Update to [email protected] #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
approved these changes
Oct 9, 2020
iand
approved these changes
Oct 9, 2020
This was referenced Oct 9, 2020
iand
reviewed
Oct 10, 2020
version/version.go
Outdated
| @@ -13,7 +15,7 @@ var reVersion = regexp.MustCompile(`^(v\d+\.\d+.\d+)(?:-)?(.+)?$`) | |||
| func String() string { | |||
| matches := reVersion.FindStringSubmatch(GitVersion) | |||
| if matches == nil || len(matches) < 3 { | |||
| return "v0.0.0+" + GitVersion | |||
| return ReleaseVersion + "+" + GitVersion | |||
There was a problem hiding this comment.
This is incorrect. This line is only encountered when there is no git tag on the repo. We should tag our versions properly.
There was a problem hiding this comment.
Oops. Thanks for raising. Will revert and manage via git tags.
placer14
force-pushed
the
chore/update-lotus-v0.9.0
branch
from
f4eb556 to
08e8528
Compare
|
Closed in favor of fix included in #84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.