-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reject invalid tasks on client #975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
What was the motivation for separating |
tasks := RunFlags.Tasks.Value() | ||
for _, taskName := range tasks { | ||
if _, found := tasktype.TaskLookup[taskName]; found { | ||
} else if _, found := tasktype.TableLookup[taskName]; found { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why twice? No objection but it's unusual.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its different. TaskLookup
vs TableLookup
where TableLookup
contains the granular task names.
Yeah, the
Yeah, it needs a DB and an API. It may be the case that drone already does some of this, do you know? |
closes #969
Ideally, this check would be performed once in a
job run
Before
option, but that would break thesurvey
command since it uses different task names. This is making me rethink if thesurvey
job should go somewhere else. Thoughts?