chore: improve distributed indexing metrics and logging #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #981 +/- ##
======================================
Coverage 34.0% 34.1%
======================================
Files 30 30
Lines 2020 2023 +3
======================================
+ Hits 687 690 +3
Misses 1256 1256
Partials 77 77 |
frrist
force-pushed
the
frrist/distributed-metrics
branch
from
fa8eadc to
f831aed
Compare
placer14
approved these changes
Jun 8, 2022
| // HasTraceCarrier returns true iff payload contains a trace. | ||
| func (i *IndexTipSetPayload) HasTraceCarrier() bool { | ||
| func (i IndexTipSetPayload) HasTraceCarrier() bool { | ||
| return !(i.TraceCarrier == nil) |
There was a problem hiding this comment.
Is access by value to prevent race conditions on i.TraceCarrier state here?
There was a problem hiding this comment.
It's because we only ever use it as a value within methods. e.g. its instantiated as a value here: https://github.com/filecoin-project/lily/pull/981/files#diff-583b89249d2ef998d0f072521baf5ae75d506958a317c2ea3e6b6ad74ac7551eR75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
lily_infometric that contains a label with the lily versionjob_runningmetric indicating which jobs are running and their type (alk, watch, fill, find, watch-notify, walk-notify, etc.)tipset_worker_concurrencyindicating concurrency configuration of tipset workerstipset_worker_queue_priorityindicating tipset worker queue priorities configuration.