Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base fee and chain capacity tracking. #99

Merged
merged 3 commits into from
Oct 14, 2020
Merged

Base fee and chain capacity tracking. #99

merged 3 commits into from
Oct 14, 2020

Conversation

frrist
Copy link
Member

@frrist frrist commented Oct 14, 2020

What

@frrist frrist requested review from iand and placer14 October 14, 2020 00:25
@frrist frrist self-assigned this Oct 14, 2020
willscott
willscott approved these changes Oct 14, 2020
View reviewed changes
tasks/message/message.go Show resolved Hide resolved
@iand iand force-pushed the frrist/messages-gas-economy branch from 3b4859f to 86b8cfd Compare October 14, 2020 12:51
@iand
Copy link
Contributor

iand commented Oct 14, 2020

Rebased onto master and changed the migration number to 10.

iand
iand approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@iand iand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iand
Copy link
Contributor

iand commented Oct 14, 2020

I'm curious what the problem was that required a '0' migration

@frrist
Copy link
Member Author

frrist commented Oct 14, 2020 •
edited
Loading

I'm curious what the problem was that required a '0' migration

When the database is first initialized we run this query (https://github.com/go-pg/migrations/blob/v8/collection.go#L620) against it to get its current version. The gopg_migration table is empty so 0 is returned (https://github.com/go-pg/migrations/blob/v8/collection.go#L624) making the dbVersion at startup 0 (https://github.com/filecoin-project/sentinel-visor/blob/master/storage/migrate.go#L39)

This bug existed before #89 and the tests added there did their job, they caught it.

@frrist frrist merged commit 54fa359 into master Oct 14, 2020
@frrist frrist deleted the frrist/messages-gas-economy branch October 14, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willscott willscott willscott approved these changes

@iand iand iand approved these changes

@placer14 placer14 Awaiting requested review from placer14

Assignees

@frrist frrist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frrist @iand @willscott