Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify dev and CI linting #990

Merged
merged 2 commits into from
Jun 18, 2022
Merged

Unify dev and CI linting #990

merged 2 commits into from
Jun 18, 2022

Conversation

frrist
Copy link
Member

@frrist frrist commented Jun 15, 2022

  • CI now matches linting in dev environments
  • Addressed new issues caught by improvmed linting

@frrist frrist marked this pull request as ready for review June 16, 2022 15:24
@frrist frrist force-pushed the frrist/fix-linter branch from 01bfdbc to acaf7e4 Compare June 16, 2022 15:29
@frrist frrist changed the title Update linting Unify dev and CI lenting Jun 16, 2022
@frrist frrist requested a review from placer14 June 16, 2022 15:33
@frrist frrist self-assigned this Jun 16, 2022
@frrist frrist changed the title Unify dev and CI lenting Unify dev and CI linting Jun 16, 2022
- CI now matches linting in dev environments
- Addressed new issues caught by improvmed linting
@frrist frrist force-pushed the frrist/fix-linter branch from acaf7e4 to a3df9e7 Compare June 16, 2022 22:24
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved

go 1.17

require github.com/Kubuxu/go-no-map-range v0.0.1
require github.com/golangci/golangci-lint v1.46.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@frrist frrist merged commit ccb9583 into master Jun 18, 2022
@frrist frrist deleted the frrist/fix-linter branch June 18, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants