test: implement miner sector event extractor tests #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frrist
commented
Jun 21, 2022
Comment on lines
-43
to
+45
| for i, sector := range sectors { | ||
| sectorChanges.Added[i] = *sector | ||
| for _, sector := range sectors { | ||
| sectorChanges.Added = append(sectorChanges.Added, *sector) |
There was a problem hiding this comment.
Fixes a panic as we need to append to Added. This is a rare case when processing the genesis block.
frrist
commented
Jun 21, 2022
| if err != nil { | ||
| return nil, err | ||
| } | ||
| } | ||
|
|
||
| sectorEventModel, err := extractSectorEvents(ctx, a, ec, sectorChanges, preCommitChanges) | ||
| dlDiff, err := miner.DiffDeadlines(ec.ParentState(), ec.CurrentState()) |
There was a problem hiding this comment.
moved to top-level method to improve testability of the different ExtractSector* methods.
Codecov Report
@@ Coverage Diff @@
## frrist/miner-sector-deals-test #999 +/- ##
================================================================
+ Coverage 29.2% 33.2% +3.9%
================================================================
Files 43 43
Lines 2693 2694 +1
================================================================
+ Hits 788 895 +107
+ Misses 1816 1697 -119
- Partials 89 102 +13 |
frrist
changed the title
kasteph
approved these changes
Jun 21, 2022
placer14
approved these changes
Jun 22, 2022
frrist
force-pushed
the
frrist/miner-sector-events-test
branch
2 times, most recently
from
f705871 to
faa82b0
Compare
frrist
force-pushed
the
frrist/miner-sector-events-test
branch
from
faa82b0 to
1082f66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.