chore: comment on why we slice the addr

filecoin-project · Feb 16, 2024 · aaeafbd · aaeafbd
1 parent 9ad8fee
commit aaeafbd
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/node/impl/full/eth_trace.go b/node/impl/full/eth_trace.go
@@ -111,6 +111,8 @@ func buildTraces(env *environment, addr []int, et *types.ExecutionTrace) error {
 		isEVM:  builtinactors.IsEvmActor(recurseInto.InvokedActor.State.Code),
 		traces: env.traces,
 	}
+	// Set capacity to the length so each `append` below creates a new slice. Otherwise, we'll
+	// end up repeatedly mutating previous paths.
 	addr = addr[:len(addr):len(addr)]
 	for i := range recurseInto.Subcalls {
 		err := buildTraces(subEnv, append(addr, subEnv.subtraceCount), &recurseInto.Subcalls[i])