document why we start EVM exit codes at 33

filecoin-project · Feb 20, 2024 · eb83497 · eb83497
1 parent cf910a8
commit eb83497
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/chain/actors/builtin/evm/actor.go.template b/chain/actors/builtin/evm/actor.go.template
@@ -19,8 +19,9 @@ import (
 
 var Methods = builtin{{.latestVersion}}.MethodsEVM
 
+// See https://github.com/filecoin-project/builtin-actors/blob/6e781444cee5965278c46ef4ffe1fb1970f18d7d/actors/evm/src/lib.rs#L35-L42
 const (
-	ErrReverted exitcode.ExitCode = iota + 33
+	ErrReverted exitcode.ExitCode = iota + 33 // EVM exit codes start at 33
 	ErrInvalidInstruction
 	ErrUndefinedInstruction
 	ErrStackUnderflow

diff --git a/chain/actors/builtin/evm/evm.go b/chain/actors/builtin/evm/evm.go
@@ -17,8 +17,9 @@ import (
 
 var Methods = builtin12.MethodsEVM
 
+// See https://github.com/filecoin-project/builtin-actors/blob/6e781444cee5965278c46ef4ffe1fb1970f18d7d/actors/evm/src/lib.rs#L35-L42
 const (
-	ErrReverted exitcode.ExitCode = iota + 33
+	ErrReverted exitcode.ExitCode = iota + 33 // EVM exit codes start at 33
 	ErrInvalidInstruction
 	ErrUndefinedInstruction
 	ErrStackUnderflow