-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate Snapcraft and AppImage #10002
Comments
Documentation Updated: |
Merged: #10090 All that remains is to deploy the deprecation notice to Snapcraft. |
Hey @ianconsolata! Just checking in here, and was wondering if we already have sent deprecation notice to Snapcraft? And if not, do you have any pointers to where we can do that? 😄 |
Ah, shoot. Dropped the ball on this. I think since Cory left, I am actually the only one with access to our release channels. All that needs to be done is:
It's pretty simple, I think I will have time to do it this week. Thanks for the reminder ping! |
@rjan90 Have the deprecated version ready to go here: https://github.com/ianconsolata/lotus/tree/snapcraft-deprecation What I did was branch of v1.18.0 (it doesn't really matter where I branch from, as long as it has the right snapcraft build steps) and I replaced all the build steps with commands to build the deprecation notice binary (
I set it up to run in CircleCI (which has the correctly configured build and deploy environment) when merged to the In order to finish deprecating, someone with permissions push my branch to the |
Thank you so much @ianconsolata 🥇! I will try to open a PR with your changes, or get some additional help from the devs |
I shared a doc (https://www.notion.so/pl-strflt/Lotus-Release-Channels-d475107f696b4669b5a0468194efb5a1) about which release channels we support, and suggesting we deprecate AppImage and Snapcraft. I just took a look again, and they are both still broken, and there is no clear path to fixing them. In the case of Snapcraft, their automated review added a new check which started failing Lotus, and none of their recommendations for fixing the issue work. For AppImage, the software we use to build the AppImage broke recently due to a malformed ubuntu version string. I brought this up in Slack, and we agreed to remove them immediately. To fully close this ticket, the following must be completed:
The text was updated successfully, but these errors were encountered: