Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate Snapcraft and AppImage #10002

Open
ianconsolata opened this issue Jan 13, 2023 · 6 comments
Open

deprecate Snapcraft and AppImage #10002

ianconsolata opened this issue Jan 13, 2023 · 6 comments
Assignees

Comments

@ianconsolata
Copy link
Contributor

ianconsolata commented Jan 13, 2023

I shared a doc (https://www.notion.so/pl-strflt/Lotus-Release-Channels-d475107f696b4669b5a0468194efb5a1) about which release channels we support, and suggesting we deprecate AppImage and Snapcraft. I just took a look again, and they are both still broken, and there is no clear path to fixing them. In the case of Snapcraft, their automated review added a new check which started failing Lotus, and none of their recommendations for fixing the issue work. For AppImage, the software we use to build the AppImage broke recently due to a malformed ubuntu version string. I brought this up in Slack, and we agreed to remove them immediately. To fully close this ticket, the following must be completed:

  • remove from docs
  • remove release automation
  • publish placeholder project with deprecation notice to snapcraft
  • remove snapcraft from release-metrics-exporter
@ianconsolata ianconsolata self-assigned this Jan 13, 2023
@ianconsolata ianconsolata converted this from a draft issue Jan 13, 2023
@ianconsolata
Copy link
Contributor Author

@ianconsolata ianconsolata changed the title deprecate Snapcraft deprecate Snapcraft and AppImage Jan 13, 2023
@ianconsolata ianconsolata moved this from In Progress to Merged in Lotus Image UX and Release Pipeline Jan 24, 2023
@ianconsolata
Copy link
Contributor Author

Merged: #10090

All that remains is to deploy the deprecation notice to Snapcraft.

@ianconsolata ianconsolata moved this from Merged to In Progress in Lotus Image UX and Release Pipeline Jan 24, 2023
@rjan90
Copy link
Contributor

rjan90 commented May 30, 2023

Hey @ianconsolata! Just checking in here, and was wondering if we already have sent deprecation notice to Snapcraft? And if not, do you have any pointers to where we can do that? 😄

@ianconsolata
Copy link
Contributor Author

Ah, shoot. Dropped the ball on this. I think since Cory left, I am actually the only one with access to our release channels. All that needs to be done is:

  • create a forked version of lotus that replaces all commands with a small message stating that Snapcraft is deprecated.
  • deploy that to Snapcraft

It's pretty simple, I think I will have time to do it this week. Thanks for the reminder ping!

@ianconsolata
Copy link
Contributor Author

@rjan90 Have the deprecated version ready to go here: https://github.com/ianconsolata/lotus/tree/snapcraft-deprecation

What I did was branch of v1.18.0 (it doesn't really matter where I branch from, as long as it has the right snapcraft build steps) and I replaced all the build steps with commands to build the deprecation notice binary (./cmd/snapcraft-deprecation/), which prints the following message:

Lotus is not distributed through Snap anymore (#10002)
Please install Lotus using another method from https://lotus.filecoin.io/lotus/install/prerequisites/

I set it up to run in CircleCI (which has the correctly configured build and deploy environment) when merged to the snapcraft-deprecation branch. I can't currently submit a PR to do that though, because that branch doesn't exist on filecoin-project/lotus.

In order to finish deprecating, someone with permissions push my branch to the filecoin-project/lotus project with the same branch. That should build the deprecation binaries, and push them to all release channels.

@rjan90
Copy link
Contributor

rjan90 commented May 31, 2023

Thank you so much @ianconsolata 🥇! I will try to open a PR with your changes, or get some additional help from the devs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants