Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lotus Eth JSON-RPC API: use Go tags to annotate methods with aliases #10608

Closed
raulk opened this issue Nov 8, 2022 · 3 comments
Closed

Lotus Eth JSON-RPC API: use Go tags to annotate methods with aliases #10608

raulk opened this issue Nov 8, 2022 · 3 comments

Comments

@raulk
Copy link
Member

raulk commented Nov 8, 2022

See

// TODO: use reflect to automatically register all the eth aliases
.

Currently we manually assign JSON-RPC operation aliases to every Eth method. Instead, specify method alises through annotations of some kind (we seem to use comments, yuck, and Go tags are only supported on structs).

Apparently some codegen magic does turn these comments into struct tags, but those are implementation details.

@Stebalien Stebalien added P2 P2: Should be resolved P3 P3: Might get resolved and removed P2 P2: Should be resolved labels Nov 8, 2022
@maciejwitowski maciejwitowski removed the P3 P3: Might get resolved label Jan 9, 2023
@maciejwitowski
Copy link
Contributor

@raulk nice to have, but not as important as testing, right? Would like to remove it from M2.1 scope.

@jennijuju
Copy link
Member

@Stebalien Stebalien transferred this issue from filecoin-project/ref-fvm Mar 31, 2023
@raulk
Copy link
Member Author

raulk commented Oct 26, 2023

We still register these aliases manually, but the effort is probably not worth the benefit, so I withdraw this.

@raulk raulk closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants