-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: eth gateway api #9863
Merged
Merged
feat: eth gateway api #9863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and skip a non-testing test; printing doesn't constitute testing.
Only when actors version is >= 10
it breaks the gen script in proxy_gen
it's in the actor state only if it is a v5 (or later) state tree
it's a dummy, but at least it makes tests pass
…ig + cleanups (#9970) Co-authored-by: raulk <[email protected]>
… and conversion methods (#9992)
travisperson
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 1 typo I believe, otherwise LGTM
magik6k
force-pushed
the
feat/eth-gateway-api
branch
from
January 13, 2023 19:08
2ec03a7
to
574b684
Compare
jennijuju
force-pushed
the
feat/eth-gateway-api
branch
from
January 14, 2023 02:11
4717f52
to
574b684
Compare
jennijuju
force-pushed
the
feat/eth-gateway-api
branch
from
January 14, 2023 02:55
1827cce
to
eadf8b6
Compare
misc: resolve conflict again
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
resolves #9816
Proposed Changes
Add eth_ rpc support to gateway
Additional Info
The actual limiter code in gateway still todo, this mostly does the plumbing for now.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps