Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we add context to actor invocations? #30

Closed
Kubuxu opened this issue Jul 15, 2019 · 6 comments
Closed

Should we add context to actor invocations? #30

Kubuxu opened this issue Jul 15, 2019 · 6 comments

Comments

@Kubuxu
Copy link
Contributor

Kubuxu commented Jul 15, 2019

No description provided.

@Kubuxu
Copy link
Contributor Author

Kubuxu commented Jul 15, 2019

Another option might be hiding it in VMContext.

@whyrusleeping
Copy link
Member

Hrm... is this just for some of the hamt methods that take a context? or do you have other reasons for wanting it through there? In general, these methods should be short, fast and not have any blocking calls.

@Kubuxu
Copy link
Contributor Author

Kubuxu commented Jul 16, 2019

Also tracing in the future, it would be very helpful for understanding flow and performance.

@whyrusleeping
Copy link
Member

hrm, yeah. that would probably be productive to have at some point.

@Kubuxu
Copy link
Contributor Author

Kubuxu commented Jul 16, 2019

Very much, I think being able to understand why for example given block took longer than usual will be critical.

@magik6k magik6k added the chain label Jul 24, 2019
@whyrusleeping
Copy link
Member

I think can be closed, we're in agreement we need to wire this through. @Kubuxu is on the job :)

magik6k added a commit that referenced this issue Aug 10, 2020
update filecoin-ffi (and related) to v26 proofs
magik6k added a commit that referenced this issue Aug 10, 2020
nonsense added a commit that referenced this issue Nov 6, 2020
testplan instantiating lotus nodes in-memory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants