Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestDealPublisher is flaky #6799

Closed
vyzo opened this issue Jul 20, 2021 · 4 comments · Fixed by #6991
Closed

TestDealPublisher is flaky #6799

vyzo opened this issue Jul 20, 2021 · 4 comments · Fixed by #6991
Labels
impact/test-flakiness Impact: Test Flakiness

Comments

@vyzo
Copy link
Contributor

vyzo commented Jul 20, 2021

As seen in https://app.circleci.com/pipelines/github/filecoin-project/lotus/15905/workflows/5d4be844-ce96-4922-ac4c-09503c0d3b3e/jobs/205203

Specifics:

=== RUN   TestDealPublisher/ignore_deals_with_cancelled_context
...
    dealpublisher_test.go:239: 
        	Error Trace:	dealpublisher_test.go:239
        	            				dealpublisher_test.go:126
        	Error:      	"[{{QmTLZn8wTHzQ4Vh9vxi68uN4HiR7EB26ro6paNMP8k61GQ %!s(abi.PaddedPieceSize=0) %!s(bool=false) f2nfm7gnbtxhjvq4bvbdnyrypubdq3xtvr2e2rw5q f24j2ie33bbjxd2oqjnf6o5qcllcbwajp7drnrqmy  20 120 0 0 0} {%!s(crypto.SigType=1) signature data}} {{QmQ3aqKBSY5r8k1CZv7FPhcPEjNG47yzSuzKpfUUgJXdB4 %!s(abi.PaddedPieceSize=0) %!s(bool=false) f2nfm7gnbtxhjvq4bvbdnyrypubdq3xtvr2e2rw5q f24j2ie33bbjxd2oqjnf6o5qcllcbwajp7drnrqmy  20 120 0 0 0} {%!s(crypto.SigType=1) signature data}} {{QmSdveHM1ShmHEjrNyLdkY9MYPyEKCgVvWXHvvbXCTP951 %!s(abi.PaddedPieceSize=0) %!s(bool=false) f2nfm7gnbtxhjvq4bvbdnyrypubdq3xtvr2e2rw5q f24j2ie33bbjxd2oqjnf6o5qcllcbwajp7drnrqmy  20 120 0 0 0} {%!s(crypto.SigType=1) signature data}}]" should have 2 item(s), but has 3
        	Test:       	TestDealPublisher/ignore_deals_with_cancelled_context
@vyzo
Copy link
Contributor Author

vyzo commented Jul 20, 2021

Also this: https://app.circleci.com/pipelines/github/filecoin-project/lotus/15905/workflows/a1a6dcc5-d7bc-4b92-95af-0b0a71443042/jobs/205231

=== RUN   TestDealPublisher/publish_deals_that_exceed_max_deals_per_message_within_publish_period,_and_one_after
...
    dealpublisher_test.go:239: 
        	Error Trace:	dealpublisher_test.go:239
        	            				dealpublisher_test.go:126
        	Error:      	"[{{Qmdx97coS2FKH2Wc1sr3fUnrw3ooicyfBcaEKQx9vdiGU2 %!s(abi.PaddedPieceSize=0) %!s(bool=false) f2nfm7gnbtxhjvq4bvbdnyrypubdq3xtvr2e2rw5q f24j2ie33bbjxd2oqjnf6o5qcllcbwajp7drnrqmy  20 120 0 0 0} {%!s(crypto.SigType=1) signature data}} {{QmRKuYmrQu1oMLHDyiA2v66upmEB5JLRqVhVEYXYYM5agi %!s(abi.PaddedPieceSize=0) %!s(bool=false) f2nfm7gnbtxhjvq4bvbdnyrypubdq3xtvr2e2rw5q f24j2ie33bbjxd2oqjnf6o5qcllcbwajp7drnrqmy  20 120 0 0 0} {%!s(crypto.SigType=1) signature data}}]" should have 1 item(s), but has 2
        	Test:       	TestDealPublisher/publish_deals_that_exceed_max_deals_per_message_within_publish_period,_and_one_after

@vyzo
Copy link
Contributor Author

vyzo commented Jul 20, 2021

I am disabling this test in #6777 (where a lot of flakes has been observed) as this hinders our ability to merge.

@Stebalien
Copy link
Member

Apparently, this is still flaky.

@Stebalien
Copy link
Member

Ok, fixed again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/test-flakiness Impact: Test Flakiness
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants