Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntwk v17 migration integration and testing #9246

Closed
5 of 6 tasks
jennijuju opened this issue Sep 2, 2022 · 2 comments
Closed
5 of 6 tasks

ntwk v17 migration integration and testing #9246

jennijuju opened this issue Sep 2, 2022 · 2 comments
Assignees
Labels
P1 P1: Must be resolved
Milestone

Comments

@jennijuju
Copy link
Member

jennijuju commented Sep 2, 2022

  • Update go-state-types

  • Migration Integration
    This will be something of a living issue -- as we develop nv17, we will have various changes to go-state-types that we'll need to integrate into Lotus (eg FIP-0041: Introduce new types go-state-types#52, FIP-0034: Modify the types for v9 go-state-types#53, FIP-0029: Add & modify types for v9 go-state-types#54).
    Each integration will likely involve work to Lotus's state abstractions as well.

  • rerunning the migration using lotus-shed with the latest RC

  • Ensuring correctness and that it's fast enough

  • Running the migration in "online" mode -- this means letting the premigration happen while the lotus daemon is syncing the chain, making sure the time and memory usage are okay

  • Param finalization: based on time and memory usage of the experiments, we need to settle on the correct number of and epochs for premigration

@jennijuju jennijuju added the P1 P1: Must be resolved label Sep 2, 2022
@jennijuju jennijuju moved this to Opportunistic in Network nv17 Sep 2, 2022
@jennijuju jennijuju added this to the Network v17 milestone Sep 2, 2022
@jennijuju jennijuju moved this from Opportunistic to Todo / In Scope in Network nv17 Sep 2, 2022
@jennijuju jennijuju moved this from Todo / In Scope to In Progress in Network nv17 Oct 3, 2022
@arajasek
Copy link
Contributor

arajasek commented Oct 7, 2022

The migration is now fully integrated, and testing has begun in #9446. Here is a list of further assertions we should make:

  • that for each pending, verified deal in v8 market, there is a corresponding allocation in v9 verifreg Allocations
  • that nextAllocationID is equal to the number of pending, verified deals in v8 market
  • that for each pending, verified deal in v8 market, there is a corresponding entry in v9 market PendingDealAllocationIds
  • that all miners that have PreCommits with deals in them have non-nil UnsealedCid, and this CID is correctly calculated:

@jennijuju
Copy link
Member Author

@arajasek did we do

Running the migration in "online" mode -- this means letting the premigration happen while the lotus daemon is syncing the chain, making sure the time and memory usage are okay ?

Repository owner moved this from In Progress to Done in Network nv17 Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 P1: Must be resolved
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants