Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shed: include invariant checks as part of migration testing #9547

Merged
merged 3 commits into from
Oct 25, 2022

Conversation

arajasek
Copy link
Contributor

Related Issues

Towards #9246

Proposed Changes

You can now run, eg., lotus-shed migrate-nv17 --check-invariants bafy2bzacedbxlti4ol2ipyd7nqhl5x6242xl4lt6twibwtnqmyt3ivfbub3y6, which will invoke the full suite of invariant checks (see here).

Note that the checks will likely take 2-3 hours to complete, and there are currently some minor invariant failures in the power actor (inherited from v8).

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner October 24, 2022 17:58
@arajasek arajasek merged commit 154fb3a into release/v1.18.0 Oct 25, 2022
@arajasek arajasek deleted the asr/invariants-fix branch October 25, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants