itests: Add tests for EthGetLogs filter combinations #10052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 tasks
iand
changed the title
raulk
reviewed
Jan 19, 2023
itests/eth_filter_test.go
Outdated
Comment on lines
1912
to
1914
| if orig == nil { | ||
| return orig | ||
| } |
Comment on lines
+103
to
+110
| decodedEntries := make([]types.EventEntry, len(ev.Entries)) | ||
| for i, entry := range ev.Entries { | ||
| decodedEntries[i] = types.EventEntry{ | ||
| Flags: entry.Flags, | ||
| Key: entry.Key, | ||
| Value: decodeLogBytes(entry.Value), | ||
| } | ||
| } |
There was a problem hiding this comment.
Doesn't this go in the opposite direction than Steb pointed out in filecoin-project/ref-fvm#1345 (1)?
raulk
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Part of #9849
Proposed Changes
TestEthGetLogswith subtests exercising filter combinations:TestEthGetLogsWithBlockRangeswith subtests testing various block rangesAdditional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps