fix: chain: put tipsetkey upon expansion of tipset #10069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raulk will be contributing a test <3 |
Closed
ZenGround0
approved these changes
Jan 19, 2023
raulk
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Honestly this seems like a workaround since we're not correcting the fact that we we are persisting tipset CIDs for unexpanded tipsets. However, if the Lotus team is happy with this solution (versus what we had in the past before this refactor was made, which worked better IMO and was cleaner IIRC), then let's go forward.
Just to check: this tipset CID will be correctly handled by the splitstore, right?
@raulk We can drop the persistence of the unexpanded tipsets. I only have it there for redundancy / to cover our bases. I can also definitely go back to what we had before, but I'm not convinced it was correct (from PR description):
I would like to understand this a bit before merging to make sure we know what we're doing and get it right this time.
Yes, anything in our main chain will be protected, TSKs that aren't in our main chain will get GCed. |
|
Confirmed that this patch fixes the issue with live syncing. After bringing up my node to speed with Hyperspace + letting it run for a few minutes, all block hashes are consistent as reported by the tool in #10060: |
|
@arajasek unfortunately I don't have the bandwidth to go digging to find an explanation now. However, I can say that the previous version of the code had been running for months in Wallaby without issues. I can't spend the time now to re-grok the Lotus sync code to understand if there'd be any missing gaps if we went back to the original version, so let's merge this and open a TODO to clean this up later? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes #10061
Proposed Changes
The bug, introduced in #9904, caused us to not put the "expanded" tipsetkey in our blockstore. We're now putting the expanded TSK.
I'm a little confused about how things were working before 9904. AFAIC tell we had the opposite bug before 9904 -- we only put the TSK when we were taking a new heaviest tipset, which does not happen during "catch-up" sync. I suspect we were missing all TSKs during catch-up sync in the previous version.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps