Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: testground build was broken #10086

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Jan 20, 2023

Related Issues

Proposed Changes

Fixes a build error when running go build -tags testground -o /dev/null ./cmd/lotus

Ci all-in-one builds have been broken for a little bit https://app.circleci.com/pipelines/github/filecoin-project/lotus/25802/workflows/0f7450bf-aced-4485-b633-20c61ae515a1/jobs/778931

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner January 20, 2023 18:29
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoff-vball geoff-vball merged commit 93b9f1a into release/v1.20.0 Jan 20, 2023
@geoff-vball geoff-vball deleted the gstuart/fix-testground-build branch January 20, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants