feat: eth: populate tx hash database on startup #10119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
force-pushed
the
gstuart/tx-hash-on-simport-napshot
branch
5 times, most recently
from
4c5182d to
3fa5057
Compare
|
I tested this on hyperspace by generating my own snapshot, and then starting a new node from the snapshot, making sure nothing fails, and all eth txs that the snapshot has messages for are added to the db. I just want to test this with a pruned store and make sure everything is okay there. |
geoff-vball
force-pushed
the
gstuart/tx-hash-on-simport-napshot
branch
from
3fa5057 to
e0326d9
Compare
jennijuju
requested review from
travisperson
and removed request for
arajasek
magik6k
approved these changes
Feb 9, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #10044
Proposed Changes
Checks all messages from the top of the chain down to a specified height (no lower than the v10 upgrade) and adds any relevant transaction hash mappings to the database. This will allow us to get transaction hash mappings when we import snapshots, or when users enable the feature for the first time.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps