Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ci: Update codeql to v2 #10120

Merged
merged 2 commits into from
Jan 26, 2023
Merged

chore: ci: Update codeql to v2 #10120

merged 2 commits into from
Jan 26, 2023

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Jan 26, 2023

Related Issues

Proposed Changes

Code QL v1 was discontinued last week. Runs are now failing. This should fix it. https://github.blog/changelog/2023-01-18-code-scanning-codeql-action-v1-is-now-deprecated/

We will also run Code QL on release branches because we have checks for it...

I couldn't find a way to get the ci check to be required. Github doesn't pick up the result of the whole workflow. I tried enabling GitHub Check on CircleCI but that literally made things worse, with the individual tests not showing up in the list in PRs

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner January 26, 2023 06:25
@geoff-vball geoff-vball force-pushed the gstuart/update-codeql branch from fa38f45 to 5463650 Compare January 26, 2023 06:31
@geoff-vball geoff-vball force-pushed the gstuart/update-codeql branch 4 times, most recently from c313d54 to ab811ed Compare January 26, 2023 07:28
@geoff-vball geoff-vball force-pushed the gstuart/update-codeql branch from ab811ed to 0cc63f6 Compare January 26, 2023 07:46
@magik6k magik6k merged commit aa0d470 into master Jan 26, 2023
@magik6k magik6k deleted the gstuart/update-codeql branch January 26, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants