-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: compute a better gas limit for recursive external contract calls #10128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisperson
force-pushed
the
feat/eth-estimate-gas
branch
3 times, most recently
from
January 26, 2023 17:18
ffa906e
to
c3dddb7
Compare
travisperson
commented
Jan 26, 2023
travisperson
force-pushed
the
feat/eth-estimate-gas
branch
from
January 26, 2023 18:22
c3dddb7
to
d1aeec7
Compare
travisperson
commented
Jan 26, 2023
travisperson
force-pushed
the
feat/eth-estimate-gas
branch
from
January 27, 2023 18:01
d1aeec7
to
a0c096d
Compare
travisperson
changed the title
Feat/eth estimate gas
feat: compute a better gas limit for recursive external contract calls
Jan 27, 2023
travisperson
commented
Jan 27, 2023
travisperson
force-pushed
the
feat/eth-estimate-gas
branch
from
January 31, 2023 14:16
23ecc21
to
94c5fcb
Compare
travisperson
force-pushed
the
feat/eth-estimate-gas
branch
3 times, most recently
from
January 31, 2023 17:11
7fae664
to
34c6b96
Compare
arajasek
reviewed
Jan 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically good to go, just some nits.
travisperson
force-pushed
the
feat/eth-estimate-gas
branch
from
February 1, 2023 18:44
96fb19d
to
30b1955
Compare
arajasek
approved these changes
Feb 1, 2023
travisperson
force-pushed
the
feat/eth-estimate-gas
branch
2 times, most recently
from
February 2, 2023 17:10
d88eb75
to
7cc1bd7
Compare
travisperson
force-pushed
the
feat/eth-estimate-gas
branch
from
February 3, 2023 20:40
7cc1bd7
to
03b419e
Compare
This was referenced Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#10041
Proposed Changes
After running
GasEstimateMessageGas
inEthEstimateGas
execute the message usingCallWithGas
to verify that the estimated gas limit (derived from the gas used) succeeds. If the message fails, double the gas limit till success is achieved (usually within 1), and then binary search to within 100,000 gas, always returning the last successful gas limit that succeeded.Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps