Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shed: Standardize use of path flag #10134

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Jan 27, 2023

Related Issues

Proposed Changes

Standardize how we pass in "path". Removes top-level env var, which could be overwritten by the default in the path variable declared in the individual functions.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner January 27, 2023 16:27
@jennijuju jennijuju added this to the Network v18 milestone Feb 4, 2023
@magik6k magik6k merged commit 83a7d6e into release/v1.20.0 Feb 9, 2023
@magik6k magik6k deleted the gstuart/shed-path-fix branch February 9, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants