Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eth: plug sqlite leak #10144

Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix: eth: plug sqlite leak #10144

merged 1 commit into from
Jan 30, 2023

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Jan 30, 2023

Related Issues

Alternative implementation of #10143

Proposed Changes

Calling db.Query() gives back a file-descriptor that has to be closed and was causing fd leaks. Since we're querying unique values, we can just call db.QueryRow() which is more succinct and doesn't cause leaks.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner January 30, 2023 15:42
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we had identified this in the original review -- glad we're fixing it!

@geoff-vball geoff-vball enabled auto-merge January 30, 2023 16:56
@geoff-vball geoff-vball merged commit 6518122 into release/v1.20.0 Jan 30, 2023
@geoff-vball geoff-vball deleted the gstuart/sqlite-leak branch January 30, 2023 17:13
@jennijuju jennijuju added this to the Network v18 milestone Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants