Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli: add ArgsUsage #10147

Merged
merged 1 commit into from
Jan 31, 2023
Merged

fix: cli: add ArgsUsage #10147

merged 1 commit into from
Jan 31, 2023

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Jan 31, 2023

Proposed Changes

  • Add ArgsUsage to commands that where missing it
  • Move check for bool flag after NArgs check on actorSetPeeridCmd and sectorsTerminateCmd
  • Change to cctx.NArg() instead of cctx.Args().xxx in a couple of places

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

fix: cli: add ArgsUsage
@rjan90 rjan90 requested a review from a team as a code owner January 31, 2023 11:03
@rjan90 rjan90 merged commit b8e7262 into master Jan 31, 2023
@rjan90 rjan90 deleted the fix/add-args-usage branch January 31, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants