tests: itests: test creating a contract and sending value #10162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
reviewed
Feb 1, 2023
itests/kit/evm.go
Outdated
|
|
||
| func (e *EVM) DeployContractFromFilename(ctx context.Context, binFilename string) (address.Address, address.Address) { | ||
| func (e *EVM) DeployContractFromFilenameValue(ctx context.Context, binFilename string, value big.Int) (address.Address, address.Address) { |
There was a problem hiding this comment.
I think this could be named DeployContractFromFileWithValue.
I think all the functions here should end with WithValue instead of just Value. I think the latter makes sense to us, but is probably ambiguous to anyone looking at this code fresh.
There was a problem hiding this comment.
There are a lot of variants here -- looks like an API cartesian product situation. This is where the functional options pattern comes in handy: https://golang.cafe/blog/golang-functional-options-pattern.html.
There was a problem hiding this comment.
Thanks @raulk @geoff-vball ! This feedback is super helpful! I have updated the PR to use WithValue
magik6k
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
filecoin-project/ref-fvm#1491
Proposed Changes
Add a test to deploy a contract that has a payable constructor. This constructor creates a new contract that it forwards value to. Test the second contract has the initial value.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps