Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: itests: test create2 and destroy #10163

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Conversation

snissn
Copy link
Contributor

@snissn snissn commented Feb 1, 2023

Related Issues

filecoin-project/ref-fvm#1491

Proposed Changes

the added test does the following:

  • deploy create2 factory contract
  • use factory to create2 destroyable contract
  • test stored address property "sender"
  • run test() which 1.calls selfdestruct 2. verifies sender() is the correct value 3. attempts and fails to deploy via create2
  • test stored property (fails)
  • deploy new contract at same address using same salt
  • verify sender() property is correct

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@jennijuju jennijuju modified the milestone: Network v18 Feb 6, 2023
@snissn snissn marked this pull request as ready for review February 6, 2023 20:42
@snissn snissn requested a review from a team as a code owner February 6, 2023 20:42
@snissn snissn enabled auto-merge (squash) February 6, 2023 20:42
@magik6k magik6k disabled auto-merge February 9, 2023 17:33
@magik6k magik6k merged commit 4f5fea8 into release/v1.20.0 Feb 9, 2023
@magik6k magik6k deleted the mikers/create2test2 branch February 9, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants