Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ethtypes: Correct 'no uncles' hash in NewEthBlock #10190

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Feb 6, 2023

Related Issues

Fixes #10176
Fixes #10183

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner February 6, 2023 13:40
@jennijuju jennijuju modified the milestone: Network v18 Feb 6, 2023
@magik6k magik6k force-pushed the fix/eth-block-unclehash branch from 4a1d657 to 5dc5684 Compare February 6, 2023 16:17
@magik6k magik6k merged commit a5043f4 into release/v1.20.0 Feb 6, 2023
@magik6k magik6k deleted the fix/eth-block-unclehash branch February 6, 2023 17:45
@jennijuju
Copy link
Member

Did you just merge without a review lolol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants