itest: fix FEVM tests for upstream changes #10193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
commented
Feb 6, 2023
| @@ -151,19 +151,19 @@ func TestFEVMRecursive2(t *testing.T) { | |||
| } | |||
|
|
|||
| // TestFEVMBasic does a basic fevm contract installation and invocation | |||
| // recursive delegate call succeeds up to 238 times | |||
| // recursive delegate call succeeds up to 228 times | |||
| func TestFEVMRecursiveDelegatecall(t *testing.T) { | |||
There was a problem hiding this comment.
This test isn't making a lot of sense to me:
recursiveDelegatecallFailhas always expected 228 successes, not 238.- If I change the "failure" loop to start at 229, the calls succeed and the test fails. But if I change the success loop to end at 238, the success loop fails.
So there appears to be a gulf between success/failure. This is not good but I'm not sure what's going on.
There was a problem hiding this comment.
also nit that the comment on top of the test is wrong
There was a problem hiding this comment.
The 30 increment in the loop makes it hard to tell what the exact threshold is
There was a problem hiding this comment.
@magik6k @Stebalien thanks 100% agree - i reorganized the test #10195
7 tasks
magik6k
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.