Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pack: add git tag to builtin_actors_gen #10200

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

snissn
Copy link
Contributor

@snissn snissn commented Feb 7, 2023

Related Issues

#10185

Proposed Changes

Pass git tag from pack.sh to builtin_actors through the makefile and add BundleGitTag to builtin_actors_gen.go

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@snissn snissn requested a review from a team as a code owner February 7, 2023 02:26
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this works well!

The only catch here is that invoking bundle-gen without the new RELEASE input will blow away the BundleGitTag previously set.

I think this is fine -- this value will only get set through the pack.sh script. The only caveat is that bundle-gen is currently invoked by make gen, a command we regularly invoke to generate other auto-generated matter (like documentation). I think the correct think to do is to just drop bundle-gen from being part of gen entirely -- it's not actually useful today anyway.

(doing so will also fix the CI failure)

@snissn
Copy link
Contributor Author

snissn commented Feb 8, 2023

Thanks @arajasek I pushed a commit that removes bundle-gen from make gen!

@jennijuju jennijuju merged commit 4c6fb21 into release/v1.20.0 Feb 8, 2023
@jennijuju jennijuju deleted the mikers/pack_add_git_tag branch February 8, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants