Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't call WalletExport in msg signing flows #10227

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Feb 9, 2023

Related Issues

Proposed Changes

Don't call WalletExport just to get key type

Additional Info

Calls to WalletExport breaks remote wallets, looks really bad in interactive wallets, and probably also breaks ledger wallet.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner February 9, 2023 22:53
@magik6k magik6k force-pushed the fix/signing-noexport branch from 4a328dd to 088d231 Compare February 10, 2023 01:38
@magik6k magik6k added the kind/bug Kind: Bug label Feb 10, 2023
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work if the msg.From is an ID address, but looking at the code that case doesn't work anyway...

@magik6k
Copy link
Contributor Author

magik6k commented Feb 10, 2023

I'm msg.From is resolved before we call into the wallet

@magik6k magik6k merged commit 1588dd3 into release/v1.20.0 Feb 10, 2023
@magik6k magik6k deleted the fix/signing-noexport branch February 10, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Kind: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants