Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eth: correctly convert filecoin message <-> eth txn #10257

Merged
merged 1 commit into from
Feb 13, 2023
Merged

fix: eth: correctly convert filecoin message <-> eth txn #10257

merged 1 commit into from
Feb 13, 2023

Conversation

Stebalien
Copy link
Member

Proposed Changes

  1. We do allow deploying with empty initcode.
  2. Make sure that the encoded "code" is non-empty, if specified.

Basically, this makes everything consistent (and it's how I specified it in the FIP).

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • Tests exist for new functionality or change in behavior
  • CI is green

@Stebalien
fix: eth: correctly convert filecoin message <-> eth txn
f07c4c5 
1. We do allow deploying with empty initcode.
2. Make sure that the encoded "code" is non-empty, if specified.

Basically, this makes everything consistent (and it's how I specified it
in the FIP).
@Stebalien Stebalien requested a review from a team as a code owner February 13, 2023 17:28
@Stebalien Stebalien requested review from arajasek and raulk February 13, 2023 17:28
raulk
raulk approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge this into #10243 as well? Should not be hard since the only path that is changing here is the contract deployment one.

@Stebalien Stebalien merged commit f427c2b into release/v1.20.0 Feb 13, 2023
@Stebalien Stebalien deleted the steb/fix-eth-txn-conversion branch February 13, 2023 18:34
@Stebalien
Copy link
Member Author

Merged.

@simlecode simlecode mentioned this pull request Feb 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arajasek arajasek arajasek approved these changes

@raulk raulk raulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stebalien @raulk @arajasek