Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eth: rename yParity to v in transaction return values #10264

Merged
merged 1 commit into from
Feb 13, 2023
Merged

fix: eth: rename yParity to v in transaction return values #10264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified build/openrpc/full.json.gz
View file
Open in desktop
Binary file not shown.
Binary file modified build/openrpc/gateway.json.gz
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion chain/types/ethtypes/eth_transactions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ type EthTx struct {
MaxFeePerGas EthBigInt `json:"maxFeePerGas"`
MaxPriorityFeePerGas EthBigInt `json:"maxPriorityFeePerGas"`
AccessList []EthHash `json:"accessList"`
V EthBigInt `json:"yParity"`
V EthBigInt `json:"v"`
R EthBigInt `json:"r"`
S EthBigInt `json:"s"`
}
Expand Down
6 changes: 3 additions & 3 deletions documentation/en/api-v1-unstable-methods.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2643,7 +2643,7 @@ Response:
"accessList": [
"0x37690cfec6c1bf4c3b9288c7a5d783e98731e90b0a4c177c2a374c7a9427355e"
],
"yParity": "0x0",
"v": "0x0",
"r": "0x0",
"s": "0x0"
}
Expand Down Expand Up @@ -2682,7 +2682,7 @@ Response:
"accessList": [
"0x37690cfec6c1bf4c3b9288c7a5d783e98731e90b0a4c177c2a374c7a9427355e"
],
"yParity": "0x0",
"v": "0x0",
"r": "0x0",
"s": "0x0"
}
Expand Down Expand Up @@ -2720,7 +2720,7 @@ Response:
"accessList": [
"0x37690cfec6c1bf4c3b9288c7a5d783e98731e90b0a4c177c2a374c7a9427355e"
],
"yParity": "0x0",
"v": "0x0",
"r": "0x0",
"s": "0x0"
}
Expand Down
60 changes: 30 additions & 30 deletions itests/specs/eth_openrpc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
"s",
"type",
"value",
"yParity"
"v"
],
"properties": {
"type": {
Expand Down Expand Up @@ -253,8 +253,8 @@
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "Chain ID that this transaction is valid on."
},
"yParity": {
"title": "yParity",
"v": {
"title": "v",
"type": "string",
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."
Expand Down Expand Up @@ -285,7 +285,7 @@
"s",
"type",
"value",
"yParity"
"v"
],
"properties": {
"type": {
Expand Down Expand Up @@ -354,8 +354,8 @@
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "Chain ID that this transaction is valid on."
},
"yParity": {
"title": "yParity",
"v": {
"title": "v",
"type": "string",
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."
Expand Down Expand Up @@ -649,7 +649,7 @@
"s",
"type",
"value",
"yParity"
"v"
],
"properties": {
"type": {
Expand Down Expand Up @@ -724,8 +724,8 @@
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "Chain ID that this transaction is valid on."
},
"yParity": {
"title": "yParity",
"v": {
"title": "v",
"type": "string",
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."
Expand Down Expand Up @@ -756,7 +756,7 @@
"s",
"type",
"value",
"yParity"
"v"
],
"properties": {
"type": {
Expand Down Expand Up @@ -825,8 +825,8 @@
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "Chain ID that this transaction is valid on."
},
"yParity": {
"title": "yParity",
"v": {
"title": "v",
"type": "string",
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."
Expand Down Expand Up @@ -3009,7 +3009,7 @@
"s",
"type",
"value",
"yParity"
"v"
],
"properties": {
"type": {
Expand Down Expand Up @@ -3084,8 +3084,8 @@
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "Chain ID that this transaction is valid on."
},
"yParity": {
"title": "yParity",
"v": {
"title": "v",
"type": "string",
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."
Expand Down Expand Up @@ -3116,7 +3116,7 @@
"s",
"type",
"value",
"yParity"
"v"
],
"properties": {
"type": {
Expand Down Expand Up @@ -3185,8 +3185,8 @@
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "Chain ID that this transaction is valid on."
},
"yParity": {
"title": "yParity",
"v": {
"title": "v",
"type": "string",
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."
Expand Down Expand Up @@ -3359,7 +3359,7 @@
"s",
"type",
"value",
"yParity"
"v"
],
"properties": {
"type": {
Expand Down Expand Up @@ -3434,8 +3434,8 @@
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "Chain ID that this transaction is valid on."
},
"yParity": {
"title": "yParity",
"v": {
"title": "v",
"type": "string",
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."
Expand Down Expand Up @@ -3466,7 +3466,7 @@
"s",
"type",
"value",
"yParity"
"v"
],
"properties": {
"type": {
Expand Down Expand Up @@ -3535,8 +3535,8 @@
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "Chain ID that this transaction is valid on."
},
"yParity": {
"title": "yParity",
"v": {
"title": "v",
"type": "string",
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."
Expand Down Expand Up @@ -3726,7 +3726,7 @@
"s",
"type",
"value",
"yParity"
"v"
],
"properties": {
"type": {
Expand Down Expand Up @@ -3801,8 +3801,8 @@
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "Chain ID that this transaction is valid on."
},
"yParity": {
"title": "yParity",
"v": {
"title": "v",
"type": "string",
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."
Expand Down Expand Up @@ -3833,7 +3833,7 @@
"s",
"type",
"value",
"yParity"
"v"
],
"properties": {
"type": {
Expand Down Expand Up @@ -3902,8 +3902,8 @@
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "Chain ID that this transaction is valid on."
},
"yParity": {
"title": "yParity",
"v": {
"title": "v",
"type": "string",
"pattern": "^0x([1-9a-f]+[0-9a-f]*|0)$",
"description": "The parity (0 for even, 1 for odd) of the y-value of the secp256k1 signature."
Expand Down