-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pack: support network name overrides in bundle git tags #10294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's still one piece of information that needs to be passed through, which is the actors version being updated. As currently written, we'll respect the network overrides, but still set all actor versions to the git tag, not just the one being packed.
As an example, ./pack.sh v9 dev/20230114-pre-rc.2 mainnet=v9.0.3 calibrationnet=v9.0.0 devnet=v9.0.3 devnet-wasm=v9.0.3 testing=v9.0.3 testing-fake-proofs=v9.0.3 butterflynet=v9.0.2
should only update v9 actors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only issue I see with this is that it's gonna skip the metadata for those versions we aren't setting, leading to them getting overwritten.
I think we can just drop the metadataSpecificVersion
, and mutate the metadata
object in place. That will modify it as needed, while leaving everything else untouched.
Related Issues
#10185 (comment)
Proposed Changes
add support for overrides
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps