Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eth: eth_subscribe tag #10309

Merged
merged 1 commit into from
Feb 17, 2023
Merged

fix: eth: eth_subscribe tag #10309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/proxy_gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion gen/api/proxygen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,8 @@ type {{.Num}}Struct struct {

type {{.Num}}Methods struct {
{{range .Methods}}
{{.Num}} func({{.NamedParams}}) ({{.Results}}) `+"`"+`{{range .Tags}}{{index . 0}}:"{{index . 1}}"{{end}}`+"`"+`
{{.Num}} func({{.NamedParams}}) ({{.Results}}) `+"`"+`{{$first := true}}{{range .Tags}}{{if $first}}{{$first = false}}{{else}} {{end}}{{index . 0}}:"{{index . 1}}"{{end}}`+"`"+`

{{end}}
}

Expand Down
4 changes: 2 additions & 2 deletions itests/deals_partial_retrieval_dm-level_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ func testDMExportAsFile(ctx context.Context, client *kit.TestFullNode, expDirect
func testV0RetrievalAsFile(ctx context.Context, client *kit.TestFullNode, retOrder api0.RetrievalOrder, tempDir string) error {
out := tempDir + string(os.PathSeparator) + "exp-test" + retOrder.Root.String()

cv0 := &api0.WrapperV1Full{client.FullNode} //nolint:govet
cv0 := &api0.WrapperV1Full{FullNode: client.FullNode}
err := cv0.ClientRetrieve(ctx, retOrder, &api.FileRef{
Path: out,
})
Expand Down Expand Up @@ -220,7 +220,7 @@ func tesV0RetrievalAsCar(ctx context.Context, client *kit.TestFullNode, retOrder
}
defer out.Close() //nolint:errcheck

cv0 := &api0.WrapperV1Full{client.FullNode} //nolint:govet
cv0 := &api0.WrapperV1Full{FullNode: client.FullNode}
err = cv0.ClientRetrieve(ctx, retOrder, &api.FileRef{
Path: out.Name(),
IsCAR: true,
Expand Down