Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gas: overestimate around the Hygge upgrade #10333

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

arajasek
Copy link
Contributor

Related Issues

#10329

Proposed Changes

Overestimate gas around the Hygge upgrade based on the projected increases in https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0057.md#product-considerations.

We don't underestimate where costs have decreased in order to be safe (this is only a 10 minute window).

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner February 23, 2023 14:36
@arajasek arajasek mentioned this pull request Feb 24, 2023
21 tasks
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd consider just making the overestimation a flat 2 for everything.

@arajasek arajasek merged commit 9fba14b into release/v1.20.0 Feb 27, 2023
@arajasek arajasek deleted the asr/overestimate branch February 27, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants