Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: state: skip tipset execution when possible #10445

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Mar 10, 2023

Proposed Changes

Instead of always executing the tipset inside StateManager.TipSetState, try to find a successor tipset and return the parent state & receipts as recorded.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@Stebalien Stebalien requested a review from a team as a code owner March 10, 2023 21:16
@Stebalien Stebalien force-pushed the steb/skip-tipset-execution branch from 5e8ed1f to 3a4cbb9 Compare March 10, 2023 21:17
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I like how simple this is!

@raulk raulk merged commit d7a2fdb into master Mar 11, 2023
@raulk raulk deleted the steb/skip-tipset-execution branch March 11, 2023 16:19
@raulk
Copy link
Member

raulk commented Mar 11, 2023

Merged so I can build on it. Thanks, @Stebalien!

@raulk
Copy link
Member

raulk commented Mar 11, 2023

Note: I think @arajasek had expressed a pet peeve against using "deeper" methods from the Eth API (e.g. a StateManager method in this case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants