Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deflake splitstore_test #10831

Closed
wants to merge 1 commit into from
Closed

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented May 4, 2023

Related Issues

This test has been observed to flake, example here. In this case, the test ran forever because the Prune couldn't start at the time it was triggered, and so we just waited endlessly for a prune that was never going to happen.

Proposed Changes

  • Do NOT mine while waiting for pruning to occur (I think by this point we don't need the chain to progress)
  • Re-send the Prune request every 5 seconds if pruning doesn't start for some reason

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner May 4, 2023 20:07
@arajasek
Copy link
Contributor Author

arajasek commented May 8, 2023

Would get superseded / rendered unnecessary by #10840

@arajasek arajasek marked this pull request as draft May 8, 2023 13:13
@arajasek arajasek closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants