Some chain CLI & API #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
feat/some-chain-cli
branch
from
bcfc217 to
1515efb
Compare
Kubuxu
reviewed
Jul 9, 2019
magik6k
force-pushed
the
feat/some-chain-cli
branch
from
1515efb to
cb35547
Compare
| return err | ||
| } | ||
|
|
||
| // TODO: anything else to do here? |
There was a problem hiding this comment.
we should import the block into our local chainstore.
Theres also the consideration of "should we do the expensive verification pass for blocks we create locally?"
There was a problem hiding this comment.
should we do the expensive verification pass for blocks we create locally
i assume that we run this validation on all incoming blocks, running this validation here seems to make sense (we'll probably create blocks less often that receive)
There was a problem hiding this comment.
Yeah, it will happen less frequently, but i guess what i'm wondering is whether we should skip it in this case, in order to start mining the next block on top of it more quickly
whyrusleeping
approved these changes
Jul 9, 2019
magik6k
added a commit
that referenced
this pull request
Aug 10, 2020
Move GenerateWinningPoStSectorChallenge to Verifier
magik6k
added a commit
that referenced
this pull request
Aug 10, 2020
Compute seal ticket internally, remove node ticket fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #9 (Merge after that one)
Some things for #10