[wip] feat: sturdypost: WindowPoSt Submit #11380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snadrus
reviewed
Nov 3, 2023
magik6k
commented
Nov 3, 2023
| @@ -24,5 +24,11 @@ create table wdpost_proofs | |||
| partition bigint not null, | |||
| submit_at_epoch bigint not null, | |||
| submit_by_epoch bigint not null, | |||
| proof_message bytea | |||
| proof_message bytea, | |||
There was a problem hiding this comment.
Should rename this to proof_params before merging
magik6k
commented
Nov 4, 2023
snadrus
requested changes
Nov 8, 2023
| @@ -64,10 +65,13 @@ func Register(db *harmonydb.DB, hostnameAndPort string) (*Reg, error) { | |||
| SELECT id FROM inserted; | |||
| `, hostnameAndPort, reg.Cpu, reg.Ram, reg.Gpu).Scan(&ownerID) | |||
| if err != nil { | |||
| return nil, err | |||
| return nil, xerrors.Errorf("inserting machine entry: %w", err) | |||
There was a problem hiding this comment.
Why not use fmt.Errorf which has %w now?
| as: as, | ||
| } | ||
|
|
||
| if err := pcs.AddHandler(res.processHeadChange); err != nil { |
There was a problem hiding this comment.
What happens for these case when the db entry is added after its submit epoch has started (potentially common for WinningPoSt)
-- a "check_now()" type of function called from the proof creator could help here.
| GasEstimateGasPremium(_ context.Context, nblocksincl uint64, sender address.Address, gaslimit int64, tsk types.TipSetKey) (types.BigInt, error) | ||
| } | ||
|
|
||
| type WdPostSubmitTask struct { |
There was a problem hiding this comment.
How generic could this be made WRT having it support WindowPoSt and/or sealing?
I ask because the database tables will be written after this goes out and any attempt to make it generic would involve data migration or an interface to swap out submit types that use different tables.
Closed
This was referenced Nov 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #11379
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps