Fix todays sql error and remember which machine did a task #11415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
approved these changes
Nov 14, 2023
| return xerrors.Errorf(`'%w' while parsing the config toml's | ||
| [Apis] | ||
| StorageRPCSecret=%v | ||
| Get it from the JSON documents in ~/.lotus-miner/keystore called .PrivateKey`, err, cfg.Apis.StorageRPCSecret) |
There was a problem hiding this comment.
Should link specifically ~/.lotusminer/keystore/MF2XI2BNNJ3XILLQOJUXMYLUMU
| @@ -0,0 +1 @@ | |||
| ALTER TABLE harmony_task_history ADD COLUMN completed_by_host_and_port varchar(300) NOT NULL; | |||
There was a problem hiding this comment.
tbh given that we're not rolled out anywhere yet, I'd say that we can afford to modify the main schema files, we can just drop the lotus schema between test runs;
(Not a super strong opinion)
There was a problem hiding this comment.
I figure it will be good to have a solid example for junior engineers.
We could go further to protect the schema state from corruption by remembering the file hash in the database and failing to start if the hash of an old file looks different.
|
@Reiers This is merged, and we are ready to continue testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps