-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deps: update FFI, FVM, and actors #11604
Conversation
I have a branch (https://github.com/filecoin-project/lotus/tree/steb/update-fvm) that updates the FVM and addresses the breaking changes to the tracing API. That branch is currently based on master, but should I move it to feat/nv22? |
Yeah, that would be ideal. Once |
Hm. That's not ideal as I want to make PRs that depend on these changes, and these PRs are not a part of nv22. I didn't realize the diff was that big. Is there any reason not to make the PR against master then back merge? Do we not do back-merging to integration branches? |
Oh, I see. Yeah, feel free to go with the path of PR against master then back merge |
@rjan90 PR looks good to me but we will need @Stebalien's changes from here before CI can be green. |
Update actors to v13.0.0-rc.1
44218ca
to
98d4a46
Compare
Update to v13.0.0-rc.2 bundle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I cherry-pick this in to feat/built-in-actor-events-api
which requires the actor events work, and I add in #11611, and I run against filecoin-project/go-state-types#236 then it's all 👍. And I even get the right "balance"
encoded form out of events which was that thing I fixed in actors yesterday:
Event<height=772, msg=bafy2bzacebadnt32yvrwugww64tymuv4zdpwl26hnv5et6js5oxxj3sokjjnq, emitter=f06, reverted=false, $type="verifier-balance", verifier=100, balance={"/":{"bytes":"ABdIdsDw"}}>
Pulled in the v13.0.0-rc.2 commit to #11611 where, by the powers of both branches combined, we get 💚 . Merged that one in to feat/nv22 so we're all good now. |
Related Issues
Towards nv22/lotus v1.26.0-rc1 release
Proposed Changes
Updates:
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps