No sed backup file #11624
No sed backup file #11624
Conversation
rvagg
force-pushed
the
rvagg/noifixbak
branch
from
81dd3e9 to
0dc20bb
Compare
|
|
||
| find . -type f -name \*.go.ifixbak | xargs rm | ||
| # Because -i works differently on macOS, we need to use a different sed command | ||
| if [[ "$OSTYPE" == "darwin"* ]]; then |
There was a problem hiding this comment.
not guaranteed to be defined?
There was a problem hiding this comment.
I think if you don't have it defined you have bigger problems than this script defaulting to the gnu sed
There was a problem hiding this comment.
Oh, I didn't realize this was a bash thing. Nvm.
| find . -type f -name \*.go.ifixbak | xargs rm | ||
| # Because -i works differently on macOS, we need to use a different sed command | ||
| if [[ "$OSTYPE" == "darwin"* ]]; then | ||
| go_files | xargs -I '{}' sed -i '' -e "$sed_replace" '{}' |
There was a problem hiding this comment.
Can we not just specify the suffix anyways?
There was a problem hiding this comment.
Oh, I see. Also, I absolutely hate macos.
Do we even need this? Can we just not delete these lines?
There was a problem hiding this comment.
I personally don't need it. But are you willing to move Chesterton's fence?
There was a problem hiding this comment.
Ah... I see why it's there. It's there because we add a bunch of newlines and goimports won't ungroup.
No description provided.