Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: spcli: sectors extend improvements #11798

Merged
merged 17 commits into from
Apr 2, 2024
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 30, 2024

Related Issues

On top of the sptool refactor - #11788

Proposed Changes

  • Add client/piece info to the skip-claim log in the sectors extend command
  • (Also make sector info epochs print with human-readable time)
  • Simulate message execution without --really-do-it
  • Fix a bug where sectors with too-short-term-max claims wouldn't be correctly skipped

Additional Info

Example output:

skipping sector 6176 because claim 19991937 (client 2097088, piece baga6ea4seaqetclihltz5l75tov5nt5sftfcal7nxbpnbt6whxpjhg63adg5yga) does not live long enough 
skipping sector 6177 because claim 19991939 (client 2097088, piece baga6ea4seaqpwwhak6s4umsywzpkrlpy5wi6vvlheuotdbr34doiu5qpd6gx4lq) does not live long enough 
skipping sector 6178 because claim 19991940 (client 2097088, piece baga6ea4seaqocgv36nivk3pthd4i4qmtx2aefcn76tf5f4stirzck2b7pj5m4ay) does not live long enough 

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k changed the title feat: spcli: Add client to claim info in sectors extend feat: spcli: sectors extend improvements Mar 31, 2024
Base automatically changed from feat/sptool to master April 1, 2024 15:30
@snadrus
Copy link
Collaborator

snadrus commented Apr 1, 2024

rebase needed? @magik6k

@magik6k magik6k requested a review from snadrus April 2, 2024 15:04
@snadrus snadrus merged commit 71fee35 into master Apr 2, 2024
183 of 184 checks passed
@snadrus snadrus deleted the feat/filplus-claim-client-info branch April 2, 2024 16:18
Nagaprasadvr pushed a commit to Nagaprasadvr/lotus that referenced this pull request Apr 4, 2024
* sptool: Initial structure

* sptool: Port lotus-miner actor withdraw

* sptool: Make cli docsgen happy

* actors are done

* info

* proving

* sptool the rest

* fixed gitignore

* lints

* oops

* 2

* terminate

* fixes

* sptool: improve sectors list

* feat: spcli: Add client to claim info in sectors extend

* spcli: Fix extend skipping sectors with claims

---------

Co-authored-by: Andrew Jackson (Ajax) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants