Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sealing: improve gasEstimate logging #11840

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented Apr 5, 2024

Related Issues

Fixes #11836

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@LexLuthr LexLuthr changed the title improve gasEstimate logging fix: sealing: improve gasEstimate logging Apr 5, 2024
@LexLuthr LexLuthr requested a review from magik6k April 5, 2024 10:03
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise looks good

storage/pipeline/utils.go Outdated Show resolved Hide resolved
@LexLuthr LexLuthr force-pushed the fix/commit-msg-err branch from a4bea28 to bf98446 Compare April 5, 2024 11:34
@LexLuthr LexLuthr merged commit c827cf1 into master Apr 5, 2024
186 checks passed
@LexLuthr LexLuthr deleted the fix/commit-msg-err branch April 5, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Miner: provide full message on log output when simulateMsgGas fails
2 participants