chore: Add Error Handling to Resolve Linting Errors #12046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks have completed ❌ Failed Check / Check (lint-all) (pull_request) |
rjan90
changed the title
rjan90
force-pushed
the
chore-fix-lint-errors
branch
from
50a08d0 to
c8764d1
Compare
rvagg
reviewed
May 27, 2024
| fmt.Fprintln(cctx.App.Writer, "actor creation failed!") | ||
| return err | ||
| if _, err := fmt.Fprintln(cctx.App.Writer, "actor creation failed!"); err != nil { | ||
| return err |
There was a problem hiding this comment.
ignore the error and return err - this branch always return err anyway
rjan90
force-pushed
the
chore-fix-lint-errors
branch
from
2c4ae90 to
4b484ee
Compare
fix: add error handling to resolve lint-errors
rjan90
force-pushed
the
chore-fix-lint-errors
branch
from
f2948f2 to
c99bc2b
Compare
fix: add error handling to resolve lint-errors
Add more error handling to resolve lint-errors
|
taken up @ #12065 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#12044
Proposed Changes
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps