-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nv24 skeleton #12419
feat: nv24 skeleton #12419
Conversation
chore: run `make gen` and `make docsgen-cli`
Doing a test run in a devnet: Network version at the start of the devnet:
I can se the pre-migration happen:
The actual migration at epoch 200:
I can see that we switch actors-bundle version and network version:
And the network is able to progress after upgrade epoch:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Did go through all the changes, and looks great.
I will have to check up on why this check is failing though, before we can merge it. Will get to that early tomorrow. |
Sorry for landing this taking a bit of time. The proposed solution for fixing the failing test, are causing even more tests to fail #12423 (comment), because of what seems to be custom test runner image in GHA and SHA extension/difference between AMD and Intel CPUs in these. If we do not get to the bottom of it before the EOW, I will propose we look past that |
fix(CI): ensure dependencies are installed before build
…oin-project#12446) * chore(deps): use new FFI_PORTABLE flag for filecoin-ffi builds * chore: update FFI to v1.30.0-dev chore: update FFI to v1.30.0-dev --------- Co-authored-by: Phi <[email protected]>
fix: update account.State import in migration test
Superseded by / changes pulled into: #12455 |
Related Issues
Closes #12351
Checklist
Before you mark the PR ready for review, please make sure that: