Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nv24 skeleton #12419

Closed
wants to merge 14 commits into from
Closed

Conversation

kamuik16
Copy link
Contributor

@kamuik16 kamuik16 commented Aug 28, 2024

Related Issues

Closes #12351

Checklist

Before you mark the PR ready for review, please make sure that:

@rjan90
Copy link
Contributor

rjan90 commented Aug 29, 2024

As discussed in DM on Slack with @kamuik16 , I have pushed the changes from running make gen and make docsgen-cli in this commit: 5038d1a.

I will review all the other commits, but get someone else to do a sanity check of the make gen / make docsgen-cli commit.

@rjan90 rjan90 marked this pull request as ready for review August 29, 2024 09:47
@rjan90 rjan90 added the skip/changelog This change does not require CHANGELOG.md update label Aug 29, 2024
@rjan90
Copy link
Contributor

rjan90 commented Aug 29, 2024

Doing a test run in a devnet:

Network version at the start of the devnet:

lotus state actor-cids
Network Version: 23
Actor Version: 14
Manifest CID: bafy2bzacebwn7ymtozv5yz3x5hnxl4bds2grlgsk5kncyxjak3hqyhslb534m
------

I can se the pre-migration happen:

2024-08-29T13:51:42.070+0200    WARN    statemgr        stmgr/forks.go:250      STARTING pre-migration
2024-08-29T13:51:42.073+0200    INFO    bundle  bundle/bundle.go:60     manifest cid: bafy2bzacebwn7ymtozv5yz3x5hnxl4bds2grlgsk5kncyxjak3hqyhslb534m
-------------
2024-08-29T13:51:42.075+0200    INFO    fil-consensus   filcns/upgrades.go:2860 All 17 done after 1.22775ms (13846/s)
2024-08-29T13:51:42.076+0200    WARN    statemgr        stmgr/forks.go:263      COMPLETED pre-migration {"duration": 0.005133791}

The actual migration at epoch 200:

2024-08-29T13:59:52.585+0200    WARN    statemgr        stmgr/forks.go:202      STARTING migration      {"height": "200", "from": "bafy2bzaceajnrelizbkhvwy2ribq6nejwlhshcsa2fjbxatqmauth6mafrgfa"}
2024-08-29T13:59:52.587+0200    INFO    bundle  bundle/bundle.go:60     manifest cid: bafy2bzacebwn7ymtozv5yz3x5hnxl4bds2grlgsk5kncyxjak3hqyhslb534m
2024-08-29T13:59:52.587+0200    INFO    fil-consensus   filcns/upgrades.go:2860 Started 7 workers
--------
2024-08-29T13:59:52.587+0200    WARN    statemgr        stmgr/forks.go:211      COMPLETED migration     {"height": "200", "from": "bafy2bzaceajnrelizbkhvwy2ribq6nejwlhshcsa2fjbxatqmauth6mafrgfa", "to": "bafy2bzaceajnrelizbkhvwy2ribq6nejwlhshcsa2fjbxatqmauth6mafrgfa", "duration": 0.002064375}

I can see that we switch actors-bundle version and network version:

lotus state actor-cids                     
Network Version: 24
Actor Version: 15
Manifest CID: bafy2bzacebwn7ymtozv5yz3x5hnxl4bds2grlgsk5kncyxjak3hqyhslb534m

And the network is able to progress after upgrade epoch:

lotus chain list
233: (Aug 29 14:01:54) [ bafy2bzacedvxxepa757myfjoo55itdaubisdgocume7yn3d4wjjdk6vobhika: t01000, ]
234: (Aug 29 14:01:58) [ bafy2bzaced3wjjf37phy34fsoirlcto4tkjtcabmtj2igobaxbueoydds24yi: t01000, ]
235: (Aug 29 14:02:02) [ bafy2bzacealopuhmu6q32g6eht2wevu7xk3gnfxf2wugavv6ca6mmcophodvw: t01000, ]
236: (Aug 29 14:02:06) [ bafy2bzacedujxxmckpkgw53rn32nljibddy6hbfj6chstygvhmc4gxxmjgcn2: t01000, ]

Copy link
Contributor

@rjan90 rjan90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Did go through all the changes, and looks great.

@rjan90
Copy link
Contributor

rjan90 commented Aug 29, 2024

Test / Cache Dependencies (pull_request)

I will have to check up on why this check is failing though, before we can merge it. Will get to that early tomorrow.

@rjan90
Copy link
Contributor

rjan90 commented Sep 3, 2024

Sorry for landing this taking a bit of time. The proposed solution for fixing the failing test, are causing even more tests to fail #12423 (comment), because of what seems to be custom test runner image in GHA and SHA extension/difference between AMD and Intel CPUs in these.

If we do not get to the bottom of it before the EOW, I will propose we look past that Cache Dependencies is failing, and merge the PR.

rjan90 and others added 6 commits September 12, 2024 09:59
fix(CI): ensure dependencies are installed before build
…oin-project#12446)

* chore(deps): use new FFI_PORTABLE flag for filecoin-ffi builds

* chore: update FFI to v1.30.0-dev

chore: update FFI to v1.30.0-dev

---------

Co-authored-by: Phi <[email protected]>
fix: update account.State import in migration test
@rjan90 rjan90 mentioned this pull request Sep 12, 2024
8 tasks
@rjan90
Copy link
Contributor

rjan90 commented Sep 12, 2024

Superseded by / changes pulled into: #12455

@rjan90 rjan90 closed this Sep 12, 2024
@kamuik16 kamuik16 deleted the nv24-skeleton branch September 12, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skeleton for nv24 to support development and testing
3 participants